Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard event modernisation #1825

Closed
ricksbrown opened this issue Aug 15, 2023 · 0 comments
Closed

Keyboard event modernisation #1825

ricksbrown opened this issue Aug 15, 2023 · 0 comments

Comments

@ricksbrown
Copy link
Member

Multiple ticking time bombs here, relying on deprecated APIs, such as:

KeyboardEvent.keyCode:
keypress Event

We should also remove the polyfill for the deprecated DOM 3 KeyEvent API.

At some point browsers will remove all the stuff we are relying on and it will simply stop working.
ricksbrown added a commit that referenced this issue Aug 16, 2023
@ricksbrown
Move off deprecated Keyboard APIs
4e9368e 
keydown and keyup are the events to use now (not keypress).
Global KeyEvent is long gone.
KeyboardEvent instances now provide .key and .code properties instead
of deprecated .keyCode and .which.   Addresses #1825
ricksbrown added a commit that referenced this issue Aug 18, 2023
@ricksbrown
Remove wc/template from bar menu
3486c73 
And fix some key handlers I missed earlier. #1822 #1823 #1825
ricksbrown added a commit that referenced this issue Aug 18, 2023
@ricksbrown
Remove keypress event from formUpdateManager
4aa5314 
And a few other updates: #1826 #1825 #1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricksbrown