-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency Lizzy to 3.0.1, change M3U text encoding to ISO-8859-1 #224
Conversation
@touwys, can you review this PR? |
|
When saving as `.m3u8`, use UTF-8 encoding
18af0c1
to
b6b3e3d
Compare
Is it imperative to rename the *.m3u playlist file extensions to the *.m3u8 file extension outside listFix() before they get added to the Playlist Directories (PD) pane? Because, the file extension can also be changed to *.m3u8 while the *,m3u files are already present in the PD. If the file extension gets renamed from *.m3u to *.m3u8 inside the listFix() PD, instead of renaming it with an external app, does it make any difference, or pose a potential risk? |
Review: listFix() 3.0.1-2_4cb01beSteps:
Annotated Screenshots: |
The safest option is to rename playlists outside listFix(). You might as well simply repair broken playlists. If the playlist turns green there is no issue. The only difference is how special characters are encoded. |
Yes, that's exactly how it's usually done. Rarely, if ever, find it necessary for another approach. Other user perspectives may differ though, and it's fitting to have that support in listFix() on standby. |
io.github.borewit:lizzy:3.0.1
Resolves #223
Playlist previously saved as
.m3u
maybe causing character encoding issues. Best to rename those to.m3u8
and load with liftFix() and save as.m3u
if required.