update to use aws-sdk-v3

[monken]

aws-sdk-js-v3 is currently in beta but will be released soon. I thought I'd give it a shot and port this package over. I don't expect this to be merged until aws-sdk-js-v3 has been released. The new SDK greatly reduces bundle sizes for applications deployed to Lambda or browser.

This is definitely a breaking change because the user will to provide a different S3 client than before.

I also adjusted the test to request a file on a public bucket (make sure to set AWS_REGION=us-east-1). I was unable to test the arrayBuffer function as it wasn't clear to me under what circumstances it is called. It would be possible to also add browser support here. So far only NodeJS is supported.

[lgtm-com]

This pull request introduces 1 alert when merging 5a2e5a9 into df3ffd3 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[Borewit]

Thanks a lot @monken.

It would be possible to also add browser support here. So far only NodeJS is supported.

Sounds good to me.

Please forgive me if I don't respond in time, I am very busy with other things at the moment. I may overlook pending things, so ping me if things or stuck.

[Borewit]

Is there a plan to support aws-sdk-js-v3?

@vecerek, as you can see @monken prepared a PR for version 3.
There is no clear plan. Probably wait until aws-sdk-js-v3 is mature, and someone is point that out.
If there is interest in V3 I don't mind to see how I can release a version to support that. At this point it is probably better to support V2 as well, right?

[vecerek]

If there is interest in V3 I don't mind to see how I can release a version to support that. At this point it is probably better to support V2 as well, right?

@Borewit I agree that it's for the better to keep supporting v2. If there's a way to provide additional support for v3, that would be awesome 🙂

[ffxsam]

I was about to totally update one of my projects to AWS SDK v3, but realized I still needed v2 for this library.

Is there some way to make aws-sdk and @aws-sdk/client-s3 both peer dependencies, so that as long as one of them is present, things will work ok?

[vecerek]

@Borewit aws-sdk-js-v3 has stable releases now: https://github.com/aws/aws-sdk-js-v3/releases

[Borewit]

Merged via #555, part of v0.2.0

[Borewit]

I was about to totally update one of my projects to AWS SDK v3, but realized I still needed v2 for this library.

Is there some way to make aws-sdk and @aws-sdk/client-s3 both peer dependencies, so that as long as one of them is present, things will work ok?

I think you can now totally update your project to V3 Sam.

[ffxsam]

@Borewit Thank you, always appreciate your help! 🙌