Sanitize vessel filenames #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boris-Barboris
requested changes
Jan 17, 2022
|
thanks! |
Lisias
pushed a commit
to net-lisias-kspu/AtmosphereAutopilot
that referenced
this pull request
Jun 12, 2023
…oris#29 from HebaruSan/fix/sanitize-vessel-filenames Sanitize vessel filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Boris-Barboris! A user posted a log on the forum, and I noticed this while investigating:
https://forum.kerbalspaceprogram.com/index.php?/topic/206468-having-unexpected-mark-stack-overflow-and-other-unexpected-crashes-in-a-modded-install/
Problem
If a user on Windows puts a
"character in a vessel's name, this is seen in the log:This causes the serialization to fail. I don't know enough about AtmosphereAutopilot to assess what else might break downstream from this.
Cause
Windows doesn't allow certain characters in filenames, including
", and AtmosphereAutopilot is trying to put user input into a filename without sanitizing it.Changes
Now this filename is passed through
KSPUtil.SanitizeFilenamebefore use (the same thing the stock game does with.craftfiles), so it will not contain illegal characters.