Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLA URL #24

Merged
merged 1 commit into from
May 3, 2018
Merged

Update CLA URL #24

merged 1 commit into from
May 3, 2018

Conversation

wmcginty
Copy link
Contributor

Fixes #23

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #24 into develop will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    93.78%   94.36%   +0.57%     
===========================================
  Files           26       26              
  Lines          981      798     -183     
  Branches        46        0      -46     
===========================================
- Hits           920      753     -167     
+ Misses          59       45      -14     
+ Partials         2        0       -2
Impacted Files Coverage Δ
Tests/DecodingTests.swift 92.95% <0%> (-3.52%) ⬇️
Tests/NetworkSessionTest.swift 80% <0%> (-3.34%) ⬇️
Tests/HTTPTests.swift 83.78% <0%> (-2.89%) ⬇️
...space/Service/Network/NetworkServiceProtocol.swift 92.3% <0%> (-1.03%) ⬇️
Tests/BackendServiceTests.swift 95.83% <0%> (-0.56%) ⬇️
Sources/Hyperspace/HTTP/HTTP.swift 100% <0%> (ø) ⬆️
...per/Test Defaults/NetworkRequestTestDefaults.swift 100% <0%> (ø) ⬆️
...es/Hyperspace/Service/Network/NetworkSession.swift 100% <0%> (ø) ⬆️
Tests/Helper/Mocks/MockNetworkService.swift 100% <0%> (ø) ⬆️
...erspace/Service/Network/NetworkServiceHelper.swift 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87b938...7c05912. Read the comment docs.

@earlgaspard earlgaspard merged commit df145a3 into develop May 3, 2018
@earlgaspard earlgaspard deleted the feature/claUpdate branch May 3, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants