Feature/request rename #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/2.0.0 #52 +/- ##
==============================================
Coverage 96.53% 96.53%
==============================================
Files 32 32
Lines 1184 1184
==============================================
Hits 1143 1143
Misses 41 41
Continue to review full report at Codecov.
|
tylermilner
suggested changes
Jul 18, 2018
There was a problem hiding this comment.
@wmcginty done reviewing. Just some minor changes and then this should be good.
CHANGELOG.md
Outdated
| [Will McGinty](https://github.com/wmcginty) | ||
| [#41](https://github.com/BottleRocketStudios/iOS-Hyperspace/pull/41) | ||
|
|
||
| * Separated the generation/encoding of the URL query from the `NetworkRequest` object into an extension `URL`. | ||
| * Separated the generation/encoding of the URL query from the `Request` object into an extension `URL`. | ||
| [Will McGinty](https://github.com/wmcginty) | ||
| [#40](https://github.com/BottleRocketStudios/iOS-Hyperspace/pull/40) | ||
|
|
There was a problem hiding this comment.
I think you're just missing a new entry in here for the actual renaming. 😉
README.md
Outdated
|
|
||
| ```swift | ||
| let createPostRequest = AnyNetworkRequest<Post>(method: .post, | ||
| let createPostRequest = AnyRequest<Post>(method: .post, | ||
| url: URL(string: "http://jsonplaceholder.typicode.com/posts")!, |
There was a problem hiding this comment.
For readability, let's get these parameters lined up.
tylermilner
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.