fix: Fixed link to pull request in raised slack messages

BottlecapDave · Jul 17, 2024 · a0f9af2 · a0f9af2
1 parent c967922
commit a0f9af2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/reminder/src/githubService.test.ts b/reminder/src/githubService.test.ts
@@ -6,7 +6,7 @@ function createRequestData(): IGitHubMergeRequestRequest {
     includeWorkInProgress: true,
     repos: [process.env.TEST_REPO as string],
     mandatoryLabels: [],
-    excludedLabels: [],
+    excludedLabels: ["dependencies"],
   }
 }
 
@@ -16,7 +16,8 @@ function getAccessToken(): string {
 
 function assertMergeRequest(mergeRequest: IGitHubMergeRequest) {
   expect(mergeRequest.head.repo.full_name).toEqual('BottlecapDave/GitHub-Pull-Request-Reminder');
-  expect(mergeRequest.user.login).toEqual('BottlecapDave');
+  expect(mergeRequest.user.login === 'dependabot[bot]' || mergeRequest.user.login === 'BottlecapDave').toEqual(true);
+  expect(mergeRequest.html_url.startsWith("https://github.com/BottlecapDave/GitHub-Pull-Request-Reminder/pull/")).toEqual(true);
 }
 
 function assertMergeRequests(mergeRequests: IGitHubMergeRequest[], includeWip: boolean, includeDraft: boolean) {

diff --git a/reminder/src/githubService.ts b/reminder/src/githubService.ts
@@ -19,7 +19,7 @@ export interface IGitHubMergeRequest {
     };
     created_at: string;
     user: IGitHubAuthor;
-    url: string;
+    html_url: string;
     labels: IGitHubLabel[];
     draft: boolean;
 }

diff --git a/reminder/src/notifiers/slackService.test.ts b/reminder/src/notifiers/slackService.test.ts
@@ -21,7 +21,7 @@ function createMergeRequests(): IGitHubMergeRequest[] {
       },
     },
     title: "Merge request with mandatory labels",
-    url: "https://gitlab.com/test/github-pull-request-reminder-test/-/merge_requests/1",
+    html_url: "https://gitlab.com/test/github-pull-request-reminder-test/-/merge_requests/1",
     draft: false,
   },
   {
@@ -36,7 +36,7 @@ function createMergeRequests(): IGitHubMergeRequest[] {
       },
     },
     title: "wip: Merge request ",
-    url: "https://gitlab.com/test/github-pull-request-reminder-test/-/merge_requests/2",
+    html_url: "https://gitlab.com/test/github-pull-request-reminder-test/-/merge_requests/2",
     draft: false,
   }]
 }

diff --git a/reminder/src/notifiers/slackService.ts b/reminder/src/notifiers/slackService.ts
@@ -26,7 +26,7 @@ export class SlackService {
                 type: "section",
                 text: {
                     type: "mrkdwn",
-                    text: `*<${request.url}|(${request.head.repo.full_name}) ${request.title}>*\n${request.user.login} | opened ${formatDistance(request.created_at, new Date())}`
+                    text: `*<${request.html_url}|(${request.head.repo.full_name}) ${request.title}>*\n${request.user.login} | opened ${formatDistance(request.created_at, new Date())}`
                 }
             })
         }