Fix LCSC numbers appearing on silkscreen #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whmountains
force-pushed
the
hide-lcsc-numbers
branch
2 times, most recently
from
2f8ee8b
to
dd073f6
Compare
|
The original push would unconditionally set the LCSC field to be hidden, but I realized that was a bit unclean. What if a user had manually set the field to be visible? We wouldn't want the plugin to make it hidden in that case. So I force-pushed a new implementation which only sets the field to visible if it did not already exist. |
whmountains
force-pushed
the
hide-lcsc-numbers
branch
from
dd073f6
to
4567589
Compare
|
Looks good to me. Just a side note, this seems to be a Linux only issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546
The Python scripting API is a bit awkward. It would be nice if
pcbnew.FOOTPRINT.SetFieldreturned the resulting field so we could callSetVisible(False)on it.I looked for ways to bypass the call to
GetFieldByName(). The source code for SetField has some ideas. But it wasn't working quite right and I would have to modify the function signature to takepcbnewas an argument for use in standalone mode. I think we would also have to modify our standalone impl to add a couple of extra stub methods.Thanks @Carbon225 for the example code showing the problem and a prototype solution.