Work in progress for ES5 on the moksha branch #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this branch is to re-enable ES5 for the webpack build. As the
npm run build
runs, the exclude pattern is echoed, as well as the inclusion pattern.I've been running it with and without this inclusion pattern, and have been working through to look for issues It is still not building proper ES5 though. It became apparent that
ipfs-mini
was creating problems, and it has been commented out from the inclusion list.Some valuable links:
To get set up with the check against ES5, install this:
Then check out this branch and install the new exclusion checker:
Then, run this to check if the build has produced proper ES5: