Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress for ES5 on the moksha branch #18

Open
wants to merge 1 commit into
base: moksha
Choose a base branch
from

Conversation

codeluggage
Copy link

@codeluggage codeluggage commented Aug 8, 2018

The purpose of this branch is to re-enable ES5 for the webpack build. As the npm run build runs, the exclude pattern is echoed, as well as the inclusion pattern.

I've been running it with and without this inclusion pattern, and have been working through to look for issues It is still not building proper ES5 though. It became apparent that ipfs-mini was creating problems, and it has been commented out from the inclusion list.

Some valuable links:

To get set up with the check against ES5, install this:

npm i es-check -g

Then check out this branch and install the new exclusion checker:

git checkout moksha-es5
npm i

Then, run this to check if the build has produced proper ES5:

npm run build && es-check es5 ./build/*.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant