Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GM Missile Guidance Compat and other small fixes #521

Merged
merged 13 commits into from
Aug 23, 2024

Conversation

lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Aug 18, 2024

In this PR, I propose changes to

  • Adds compats for GM missiles/rockets referencing TCVM's other work within this addon and in ACE
    • There is a wild stab at the Milan parameters in this PR.
  • Add missile guidance compatibility for the CUP dragon
  • Override JSRS's soundset so the distance pops of the Dragon don't sound like large explosions.
  • Accidentally tab->spaces the CWR compat

Posting this for feedback.

TODO

  • Find Milan parameter reference and update w/ that. that seem fun.

@kil0byt3
Copy link
Member

kil0byt3 commented Aug 18, 2024

This is a based PR

I'll review when I am at my PC tomorrow (and when you're done) but ty for all of the work.

@lambdatiger
Copy link
Contributor Author

I'm happy with how it is, try it out and provide any feedback you might have.

@lambdatiger lambdatiger marked this pull request as ready for review August 21, 2024 16:33
@TheCandianVendingMachine
Copy link
Contributor

still approved

@PabstMirror PabstMirror merged commit 9e6e909 into BourbonWarfare:master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants