CORE-1916 fix keychain and queue #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdee
reviewed
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added support for secure coding on newer versions of iOS, we found archiving on Keychain and the network queue was failing due to mismatched types. This PR fixes both those issues.
For keychain, we only store NSDate. The code has been updated to always expect NSDate.
For the network queue, there was a refactor to improve testability around archive and unarchive of the network queue. The main change is that we only allow some classes to be archived and retrieved. For older versions of iOS and the SDK, we filter on archive and retrieval.