Merge pull request #23 from JanMikes/fix-ignored-slimConfiguration

Fix ignored slimConfiguration setting
BrandEmbassy · Dec 7, 2018 · 62bbb25 · 62bbb25
2 parents 554551f + 42d459b
commit 62bbb25
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/SlimApplicationFactory.php b/src/SlimApplicationFactory.php
@@ -40,7 +40,7 @@ public function __construct(array $configuration, Container $container)
 
     public function create(): SlimApp
     {
-        $app = new SlimApp($this->configuration);
+        $app = new SlimApp($this->configuration['slimConfiguration']);
 
         $configuration = $this->getConfiguration($this->configuration['apiDefinitionKey']);
 

diff --git a/tests/SlimApplicationFactoryTest.php b/tests/SlimApplicationFactoryTest.php
@@ -20,6 +20,14 @@
 final class SlimApplicationFactoryTest extends TestCase
 {
 
+    public function testShouldPassSettingsToSlimContainer(): void
+    {
+        $app = $this->createSlimApp();
+        $settings = $app->getContainer()->get('settings');
+
+        $this->assertSame('Dummy', $settings['myCustomOption']);
+    }
+
     public function testShouldAllowEmptyErrorHandlers(): void
     {
         $this->createSlimApp(__DIR__ . '/configNoHandlers.neon');

diff --git a/tests/config.neon b/tests/config.neon
@@ -43,5 +43,6 @@ slimApi:
     slimConfiguration:
         settings:
             removeDefaultHandlers: true
+            myCustomOption: 'Dummy'
 
     apiDefinitionKey: "api"