Skip to content

Commit

Permalink
test: check socketOnDrain where needPause is false
Browse files Browse the repository at this point in the history
Adds a tests that checks if we can start reading again
from a socket backing an incoming http request.

PR-URL: nodejs#17654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  • Loading branch information
Leko authored and mcollina committed Dec 15, 2017
1 parent e20af33 commit a364e7e
Showing 1 changed file with 52 additions and 0 deletions.
52 changes: 52 additions & 0 deletions test/parallel/test-http-hightwatermark.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');
const http = require('http');

// These test cases to check socketOnDrain where needPause becomes false.
// When send large response enough to exceed highWaterMark, it expect the socket
// to be paused and res.write would be failed.
// And it should be resumed when outgoingData falls below highWaterMark.

let requestReceived = 0;

const server = http.createServer(function(req, res) {
const id = ++requestReceived;
const enoughToDrain = req.connection.writableHighWaterMark;
const body = 'x'.repeat(enoughToDrain);

if (id === 1) {
// Case of needParse = false
req.connection.once('pause', common.mustCall(() => {
assert(req.connection._paused, '_paused must be true because it exceeds' +
'highWaterMark by second request');
}));
} else {
// Case of needParse = true
const resume = req.connection.parser.resume.bind(req.connection.parser);
req.connection.parser.resume = common.mustCall((...args) => {
const paused = req.connection._paused;
assert(!paused, '_paused must be false because it become false by ' +
'socketOnDrain when outgoingData falls below ' +
'highWaterMark');
return resume(...args);
});
}
assert(!res.write(body), 'res.write must return false because it will ' +
'exceed highWaterMark on this call');
res.end();
}).on('listening', () => {
const c = net.createConnection(server.address().port, () => {
c.write('GET / HTTP/1.1\r\n\r\n');
c.write('GET / HTTP/1.1\r\n\r\n');
c.end();
});

c.on('data', () => {});
c.on('end', () => {
server.close();
});
});

server.listen(0);

0 comments on commit a364e7e

Please sign in to comment.