[MI-2337]: Supported filtering on comment visibility for subscriptions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...omponents/data_selectors/jira_commentvisibility_selector/jira_commentvisibility_selector.tsx
Show resolved
Hide resolved
...omponents/data_selectors/jira_commentvisibility_selector/jira_commentvisibility_selector.tsx
Show resolved
Hide resolved
1. Improved code quality 2. Improved quality of comments
1. Improved code quality 2. Changed few names
Kshitij-Katiyar
approved these changes
Nov 22, 2022
1. Improved code quality
avas27JTG
reviewed
Nov 23, 2022
...omponents/data_selectors/jira_commentvisibility_selector/jira_commentvisibility_selector.tsx
Outdated
Show resolved
Hide resolved
1. Improved code quality 2. Improved comments quality
avas27JTG
reviewed
Nov 23, 2022
...omponents/data_selectors/jira_commentvisibility_selector/jira_commentvisibility_selector.tsx
Outdated
Show resolved
Hide resolved
1. Improved code quality
avas27JTG
approved these changes
Nov 23, 2022
…nt visibility filter (#20) * [MI-2384]: Converted class component to functional component of comment visibility filter * [MI-2384]: Review fixes done 1. Improved code quality 2. Fixed lint errors * [MI-2384]: Review fixes done 1. Improved code quality * [MI-2384]: Logged the error properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.