Fix Doctrine mapping errors #157
Conversation
| #[ORM\ManyToOne(targetEntity: ValidatorInterface::class, cascade: ['persist'], inversedBy: 'conditions')] | ||
| #[ORM\JoinColumn(onDelete: 'CASCADE')] | ||
| protected ?ValidatorInterface $validator = null; | ||
|
|
There was a problem hiding this comment.
Looks good. Just need to add this to the Upgrade.md
There was a problem hiding this comment.
Do you mean in case someone implemented a custom validator and needs to add the property now? Or what else would need to be covered in the Upgrade.md file?
I assume you mean the UPGRADE-4.md file, right?
There was a problem hiding this comment.
Yep exactly and the file name is fine.
There was a problem hiding this comment.
Will take care of this in the next few days. Thanks for your insights!
There was a problem hiding this comment.
Done. Wasn't sure about the wording or how much information we should add. If you feel I should adapt things, let me know.
|
Works for me, thanks for the support. Tagged as 4.0.3. |
|
Always happy to help! |
Correct some Doctrine mapping errors, see #156 for details.