-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solved the problem where when setting all options with selected … #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any suggestion regarding the implementation, if it's the best way, if it can be improved and how to improve it, or how to better test it, is welcome! |
…et/ion into 726-fix-deselect-ion-chip
Deeved
approved these changes
Jul 6, 2023
lucas-emmanuel-brisa
approved these changes
Jul 6, 2023
iurynogueira
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 726
fix #726
Description
Leave control of selected and unselected options to the developer. To be able to deselect the dropdown options as needed.
Proposed Changes
How to Test
View Storybook
Storybook
Compliance
Concluding
This PR, while simple, makes a big change to the behavior of selected chip options. Check well in your projects.