Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solved the problem where when setting all options with selected … #730

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

AlyssonMascarenhas
Copy link
Contributor

@AlyssonMascarenhas AlyssonMascarenhas commented Jul 5, 2023

Issue 726

fix #726

Description

Leave control of selected and unselected options to the developer. To be able to deselect the dropdown options as needed.

Proposed Changes

  • Whoever implements it will have to control the options selected on their side

How to Test

  • Implement a chip with options, and in some given flow set the options to unselected.

View Storybook

Storybook

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

Concluding

This PR, while simple, makes a big change to the behavior of selected chip options. Check well in your projects.

@AlyssonMascarenhas
Copy link
Contributor Author

Issue 726

fix #726

Description

Leave control of selected and unselected options to the developer. To be able to deselect the dropdown options as needed.

Proposed Changes

  • Whoever implements it will have to control the options selected on their side

How to Test

  • Implement a chip with options, and in some given flow set the options to unselected.

View Storybook

Storybook

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

Concluding

This PR, while simple, makes a big change to the behavior of selected chip options. Check well in your projects.

Any suggestion regarding the implementation, if it's the best way, if it can be improved and how to improve it, or how to better test it, is welcome!

@AlyssonMascarenhas AlyssonMascarenhas self-assigned this Jul 5, 2023
@iurynogueira iurynogueira added the WIP Work in progress label Jul 5, 2023
@AlyssonMascarenhas AlyssonMascarenhas removed the WIP Work in progress label Jul 6, 2023
@AlyssonMascarenhas AlyssonMascarenhas merged commit 21bd4ac into main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: deselect ion-chip options with dropdown via developer implementation
5 participants