Fix compatibility issues in sordino.py and update manifest styling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- _traj_apply_extension_factors: missing enumerate on loop - _rotate_dataobj: path for oblique matrix, convert to integer
Removed several obsolete and redundant files to simplify the directory layout.
- Updated `sordino.py` to resolve a bug caused by dependency changes. - Polished style and versioning in the plugin manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses a compatibility bug in
sordino.pycaused by recent updates to a dependent module. Additionally, it includes updates to the styling and versioning of our plugin manifest to maintain consistency and readability.Changes
Bug Fix in sordino.py: Updated the
sordino.pyfile to fix a compatibility issue that emerged after a dependency was updated. This change ensures that our module remains functional and stable with the latest versions of our dependencies.Manifest Styling Update: Improved the formatting and versioning information in the plugin manifest. These changes are aimed at enhancing readability and ensuring that our versioning practices are up to date.
Motivation
The updates to the dependent modules necessitated adjustments in
sordino.pyto prevent potential disruptions in functionality. The changes to the manifest are part of ongoing efforts to improve the clarity and management of our project documentation and settings.Testing
sordino.pyoperates seamlessly with the updated dependencies.Please review the changes and merge this pull request if everything is in order. Feedback is welcome for any further adjustments required.