Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in filter_isoforms_by_proportion_of_gene_expr.py #261

Closed
eschiks opened this issue Jun 7, 2023 · 1 comment
Closed

Error in filter_isoforms_by_proportion_of_gene_expr.py #261

eschiks opened this issue Jun 7, 2023 · 1 comment

Comments

@eschiks
Copy link

eschiks commented Jun 7, 2023

I was getting an error message when using a --support value below 0 for the collapse module. There was an error in the script filter_isoforms_by_proportion_of_gene_expr.py. I changed 2 lines, which fixed it:

line 58: gene_total = float(sum([float(iso[0][-1]) for iso in genes[gene]])) CHANGED TO gene_total = float(sum([float(iso[-1]) for iso in genes[gene]]))

line 62: if float(iso[0][-1])/gene_total >= s: CHANGED TO if float(iso[-1])/gene_total >= s:

It works fine for me now, just wanted to alert you of this issue!

@Jeltje
Copy link
Collaborator

Jeltje commented Jun 9, 2023

That's quite a big bug you found there, thanks! Fixed. Will do new release soon.

@Jeltje Jeltje closed this as completed Jun 9, 2023
Jeltje added a commit that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants