Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Creating canvas with width or height of zero or less #739

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix: Creating canvas with width or height of zero or less #739

merged 3 commits into from
Oct 14, 2024
+30 −5

Conversation

kaloyanBozhkov
Copy link
Contributor

Should solve #713

@yisibl
Copy link
Collaborator

yisibl commented Oct 25, 2023

Thanks, please add test cases.

@twlite
Copy link
Contributor

twlite commented Jan 23, 2024

@kaloyanBozhkov you probably need to do it for svg canvas also

canvas/src/ctx.rs

Line 54 in f88b8fe

pub fn new_svg(

@Brooooooklyn Brooooooklyn force-pushed the fix-create-canvas-width-height-zero branch from d05ee82 to 7f1f5aa Compare October 14, 2024 02:05
@Brooooooklyn Brooooooklyn merged commit 3a26c7d into Brooooooklyn:main Oct 14, 2024
29 checks passed
@twlite twlite mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaloyanBozhkov @yisibl @twlite @Brooooooklyn