-
Notifications
You must be signed in to change notification settings - Fork 756
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow domain to be set in socket options
- Loading branch information
1 parent
985682c
commit b2fa337
Showing
4 changed files
with
35 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<script type='text/javascript' id="__bs_script__">//<![CDATA[ | ||
document.write("<script %async%src='%script%'><\/script>".replace("HOST", location.hostname)); | ||
document.write("<script %async% src='%script%'><\/script>".replace("HOST", location.hostname)); | ||
//]]></script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2fa337
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular change broke some functionality for me. When hosting behind a load balancer / proxy which uses a different combination of https or ports, the client script no longer points to the external URL, but rather uses the internal one. This is similar to the issue referencing this commit about "Docker" support.