-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security: Update vulnerable dependencies #1659
Conversation
I see the AppVeryor build for node 4 failed - looks like there was a checksum mismatch while installing |
@shakyShane have you had a chance to take a look? I haven't used AppVeyor, but I suspect a contributor to the library will be able to re-run the failed job. (I did some reading and AppVeyor is apparently prone to network and connectivity glitches, which may explain the failed install.) |
@rouanw You can try closing and re-opening to retrigger CI. |
any updates on this? |
any news when this will be fixed? |
up, any news on that? |
@shakyShane Can you please have a look and retrigger the AppVeyor build? It'd be great to have a new release with these updates. Please let me know if there is something we could help with, I guess people are eagerly waiting for a new version which incorporates the vulnerability fixes. Thanks! |
There hasn't been any commit activity for the last half year and not receiving an answer here makes me wonder, whether or not this repo is still maintained. As I said I'd be willing to help out, since I'm relying on BrowserSync in several of my projects and I'd rather not see this project fade away. |
I'm looking into all security related PRs now :) |
fixed in 2.26.4, thanks for your contribution :) |
@shakyShane Is there a reason why you don't merge people's contribution and instead of copying what they did? |
@Berkmann18 just in this case, there were 4 different open PRs, all with slightly different fixes. This happened purely because I was absent for so long, something I regret and am sorry for. Once I did get around to this, with only of hours to spare I made the decision to perform all updates in 1 go, rather than attempt to cherry pick bits and pieces spread across 4 PRs. I value PRs greatly, and have accepted/merged many in the past - but for this one, just because of time restraints, I decided against it. Hope that clears it up, and doesn't discourage further contributions in the future |
@shakyShane Thanks for the clarification. |
This Pull Request addresses some vulnerabilities reported by
npm audit
:lerna
(minor version)micromatch
(major version, but themicromatch
maintainers assert the API is unchanged - see https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md#300---2017-04-11)lodash-cli
(I couldn't see any usages of this library)@shakyShane do you mind taking a look please?