Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend JPEG XL detection/recognition (also AVIF a tiny bit) #3262

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Extend JPEG XL detection/recognition (also AVIF a tiny bit) #3262

merged 3 commits into from
Nov 17, 2023

Conversation

goodusername123
Copy link
Contributor

Adds JPEG XL recognition to a few missing spots, Should hopefully fix issue #2962 however I can't test myself since I don't have a setup to compile Waterfox builds of my own.

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Nov 13, 2023 •
edited
Loading

Thanks for submitting. Will take a look and revert.

@goodusername123
Copy link
Contributor Author

goodusername123 commented Nov 15, 2023 •
edited
Loading

@MrAlex94
After doing another pass over the codebase I have come to realize there are quite a few spots that I have missed, Would it be fine if I attached another commit to this pull request with the extra places I originally missed? or would you prefer a separate pull request? The commit would be larger then the other ones currently present and would also include adding JXL as a supported file association type under Windows, along with some minor spots where AVIF recognition is also missing.

@MrAlex94
Copy link
Collaborator

You can push it here, no problem. I typically squash down commits to keep it manageable for rebasing on top of gecko-dev

@goodusername123
Extend JPEG XL detection/recognition even more (plus AVIF a tiny bit).
5bf097b 
- registers JXL file association under Windows (also fixes WebP not being removed when uninstalling).
- adds JXL and AVIF as recognized image types in file picker dialog.
- adds JXL and AVIF to WebExtension downloads.download API.
- adds JXL to some inactive part of code for completeness sake.
@goodusername123 goodusername123 changed the title Extend JPEG XL detection/recognition Extend JPEG XL detection/recognition (also AVIF a tiny bit) Nov 15, 2023
@MrAlex94
Copy link
Collaborator

Thanks for the updated commits. Will revert ASAP.

@MrAlex94 MrAlex94 merged commit f28b1e9 into BrowserWorks:current Nov 17, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodusername123 @MrAlex94