Selector improvement and code cleanup #3369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry-picked from: libjxl/libjxl@d4e67a6
…a=RyanVM" This reverts commit 86fdbff.
Improved the download button selector and removed unused and non-functional code (still WIP) Signed-off-by: FaySmash <30392780+FaySmash@users.noreply.github.com>
1 task
…ty and loosen restrictions on component types - r=Standard8, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D201313
…diannaS Original Revision: https://phabricator.services.mozilla.com/D203103 Differential Revision: https://phabricator.services.mozilla.com/D204101
So as to not change load timing from stylo threads.
…:move a=diannaS Original Revision: https://phabricator.services.mozilla.com/D202796 Differential Revision: https://phabricator.services.mozilla.com/D204061
…ase a=diannaS Original Revision: https://phabricator.services.mozilla.com/D202797 Differential Revision: https://phabricator.services.mozilla.com/D204062
…y during release a=diannaS The causes of the runnable loop are as follows: 1. In Release we have a special case to make sure OnStart&OnStop are always called. We do this by dispatching a runnable that calls DoNotifyListener. 2. DoNotifyListener is called, then the reference to the channel is again dropped. But at this point only OnStartRequest was called, and ContinueDoNotifyListener was added to mEventQ. That means another runnable would be dispatched. While the loop was broken in the previous patch, we still want to ensure OnStopRequest is called before the channel is released, so this patch adds an argument to DoNotifyListener to select whether ContinueDoNotifyListener should be called synchronously or dispatched to mEventQ. Original Revision: https://phabricator.services.mozilla.com/D202798 Differential Revision: https://phabricator.services.mozilla.com/D204063
…-update, r=dsmith Differential Revision: https://phabricator.services.mozilla.com/D204210
…X_115_9_0esr_BUILD1 a=release CLOSED TREE DONTBUILD
…X_115_9_0esr_BUILD2 a=release CLOSED TREE DONTBUILD
…-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D204888
…ration r=spohl a=RyanVM This removes all the memory allocations which we were doing while writing a minidump of the crashed process from within the process itself. Under these conditions all threads are stopped save for the minidump writer; so if another thread owns a mutex guarding the memory allocator we could deadlock by doing allocations. This patch avoids allocating strings entirely and uses Breakpad's alternative allocator to sidestep the issue where we cannot avoid allocations. Differential Revision: https://phabricator.services.mozilla.com/D201960
Original Revision: https://phabricator.services.mozilla.com/D202361 Differential Revision: https://phabricator.services.mozilla.com/D202763
…X_115_9_0esr_RELEASE a=release CLOSED TREE DONTBUILD
…eadfp r=saschanaz readfp is deprecated since Python 3.2 Differential Revision: https://phabricator.services.mozilla.com/D190532
…ild-system-reviewers,sergesanspaille Differential Revision: https://phabricator.services.mozilla.com/D190285
…ortlib r=saschanaz CLOSED TREE Following the official migration guide from https://docs.python.org/3/whatsnew/3.12.html#imp Differential Revision: https://phabricator.services.mozilla.com/D190465
|
Sorry for the mess in commits - if your rebase your change ontop of the latest HEAD, should get cleaned up (may require a force push to your branch). I tested this, but when en-US remains the default, the button detection no longer works at all. Without patch: With patch: |
Improved the download button selector and removed unused and non-functional code (still WIP) Signed-off-by: FaySmash <30392780+FaySmash@users.noreply.github.com>
Hi Alex, thanks for getting back at me. I changed the JS Selector to identify the button to this: Which works in my case: As I noted, this PR is not final and still needs work (currently even if the button appears, the installation still doesn't work) |
MrAlex94
force-pushed
the
current
branch
6 times, most recently
from
101edb3
to
b5d6815
Compare
MrAlex94
force-pushed
the
current
branch
4 times, most recently
from
34f1d0c
to
6f4550f
Compare
MrAlex94
force-pushed
the
current
branch
2 times, most recently
from
d1e5532
to
e35d968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the download button selector and removed unused and non-functional code (still WIP)
The old code only worked on the English version of the Chrome Web Store because it searched for "Add to Chrome", which changes with different localization. I made the selector generic to work on all languages. I also found that the function
parentNodeUntildoesn't get called and thebrowser.runtime.onMessageandbrowser.runtime.sendMessagedon't work and also don't have any purpose (?).The installation still doesn't work tho, also the
uninitfunction doesn't get called so this PR isn't final but servers as a base for further improvements.