Windows: proper scaling for main EXE/logo Icon. #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so that the icon for the main EXE/logo displays properly at different sizes by adding pre-scaled image sizes like .ico wants. note: each of the generated image sizes has proper gamma correct scaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that the icon for the main EXE/logo displays properly at different sizes by adding pre-scaled image sizes like .ico format wants. note: each of the image sizes where generated with proper gamma correct scaling.
This and other similar things could probably be done for the other assets present in the branding folder however this is the most noticeable instance and I would rather just submit this then sit on it longer then I already have.
Before and After screenshots for the taskbar and task manager (the jagged pixel looking one is the old one before this pull request):
