-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for user groups adding users to app user metadata tables #10120
Conversation
… app sync from pulling in group users which do not actually have access to the app.
… this - also setting worker memory limits for Node 16.10+ - where a leak can occur.
…es in server which are stopping shutdown of Jest suite.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #10120 +/- ##
============================================
+ Coverage 50.23% 68.70% +18.46%
============================================
Files 222 511 +289
Lines 6109 19196 +13087
Branches 988 3889 +2901
============================================
+ Hits 3069 13188 +10119
- Misses 2169 5550 +3381
+ Partials 871 458 -413
... and 432 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ll coverage automatically.
Description
There was an issue that caused user's added to groups to be added to all app user metadata tables - this includes a small fix for it.
The majority of the work in this PR was around testing, there has been issues with the server testing before now, I've updated Jest and I believe this should resolve the issue we've been seeing where the server tests haven't been running correctly/haven't been showing coverage. Updating jest also broke a few test cases (namely snapshot tests) which required updates.
Also ran into some issues with Node 16.10+ versions, it seems that we have introduced an issue with the switch to
swc
- I spent a lot of time looking into this, our tests were leaking memory, but it turns out this is a known issue with Node 16.10+ and Jest + SWC. jestjs/jest#7874 (comment)There are also some other various fixes/improvements due to the way Jest expect changed a bit.
NOTE: most of the LoC changed here are from the yarn.lock being massively updated due to all the Jest library updates.
Addresses: