Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag ai correctly for premium #14959

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

shogunpurple
Copy link
Member

Description

Fixing an issue described in #14958 (comment) which causes AI columns to be rolled out for premium self host users - updated the areas of the code so it respects the overall feature flag ahead of the AI launch

@shogunpurple shogunpurple requested a review from a team as a code owner November 4, 2024 22:28
@shogunpurple shogunpurple requested review from adrinr and removed request for a team November 4, 2024 22:28
Copy link

qa-wolf bot commented Nov 4, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the size/s label Nov 4, 2024
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of duplicated checks. Maybe worth either having some helpers or adding the license check within the feature flag check

@shogunpurple
Copy link
Member Author

shogunpurple commented Nov 4, 2024

@adrinr I considered this but the overall feature flag will be removed after the release, so I'll do another PR to remove it. This is the first paid feature that we have feature flagged, so it requires both checks unfortunately - the overall one and in the license

@shogunpurple shogunpurple merged commit 2d8a321 into master Nov 4, 2024
13 checks passed
@shogunpurple shogunpurple deleted the flag-ai-correctly-for-premium branch November 4, 2024 23:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@adrinr
Copy link
Collaborator

adrinr commented Nov 5, 2024

@adrinr I considered this but the overall feature flag will be removed after the release, so I'll do another PR to remove it. This is the first paid feature that we have feature flagged, so it requires both checks unfortunately - the overall one and in the license

Ok, it makes sense if it's a hard one to tackle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants