Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type to find networks instead of choosing them by role="option" in cypress tests #147

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

portdeveloper
Copy link
Member

Description

This PR:

  • Changes the way that the networks are selected from the dropdown:
    Instead of clicking on the dropdown and looking for a something with [role="option"], we click on the dropdown menu, start typing the network name, and click on the first result that appears:
    cy.get("#react-select-container") .click() .find("input") .first() .type(networkName, { force: true }) .type("{enter}", { force: true });

  • Changes the way Custom chains dropdown entry is selected to the method above

  • Removes the 1000 ms delay on the proxy contract on Base test

I have tested these changes at least 50 times on my local instance but cypress may behave differently on gh actions

Additional Information

Related Issues

Fixes #146

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 6:35am

@portdeveloper portdeveloper changed the title Type to find networks instead of choose them by roles Type to find networks instead of choosing them by role="option" in cypress tests Aug 28, 2024
Copy link
Collaborator

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 50 times? haha

Good job @portdeveloper !!!

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! tested locally and works nicely on CI too, Tysm @portdeveloper!

@technophile-04 technophile-04 merged commit 170630b into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot find role:option on cypress e2e tests
3 participants