Social Recovery Wallet Challenge #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to deploy social recovery wallet
I just created the new branch. You can point this PR to that one now instead of main. |
Done |
escottalexander
requested changes
May 31, 2024
plus custom revert error
from Deploy script
|
@escottalexander thanks for the review! I believe I've addressed all your comments |
escottalexander
requested changes
Jun 4, 2024
|
@escottalexander thanks for taking the time for the further review! I made all the changes you commented about |
escottalexander
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Description
Creates the Social Recovery Wallet Challenge.
@escottalexander I think you'll need to create a
social-recoverybranch to merge this intoSome potential extra credit features