Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active grants page #134

Merged
merged 6 commits into from
Aug 12, 2024
Merged

active grants page #134

merged 6 commits into from
Aug 12, 2024

Conversation

technophile-04
Copy link
Member

@technophile-04 technophile-04 commented Aug 11, 2024

Description:

NOTE: We need to add index on "approvedAt"
Please feel free to close this PR! Since it was just copy paste and we already displaying all WIP grants (checkout #133)

Currently we were showing full list of active grants in landing page itself in the table view. This PR's limit grants displayed on home page to 8 and then creates /active-grant page with cards view.

Screen.Recording.2024-08-11.at.1.03.38.PM.mov

Copy link

vercel bot commented Aug 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:52pm

@carletex
Copy link
Contributor

Thanks @technophile-04!!

At first, I thought about an admin route for this, but this makes sense too.

NOTE: We need to add index on "approvedAt"

Just created it, it's building atm.

Question: How is the new page being cached? I think we want it to be fresh all the time.

@carletex
Copy link
Contributor

Oh, let's add a link to the new page in /admin! (maybe on the right corner? above completed grants)

@technophile-04
Copy link
Member Author

At first, I thought about an admin route for this, but this makes sense too.

Yeah even I had this in my mind but while tackling realised that it was already public so kept it as it.

Question: How is the new page being cached? I think we want it to be fresh all the time.

Ohh shit nice catch! actually it was completely static :
Screenshot 2024-08-12 at 7 09 37 PM

Update at 26df0c3 so get always fresh data.

let's add a link to the new page in /admin! (maybe on the right corner? above completed grants)

Yup, update at 20448e5 :

image

Not sure whats the best place, maybe we keep it at Header instead? and show only when admin is logged in?

@carletex
Copy link
Contributor

Ohh shit nice catch! actually it was completely static :

I always forget how caching works in NextJS app router. But my mental model is that if you don't do anything explicit, probably the stuff is going to be cached :D

Not sure whats the best place, maybe we keep it at Header instead? and show only when admin is logged in?

I moved it here for now. Seems like a decent place that doesn't get in the middle.

image

@carletex carletex merged commit f5ff154 into main Aug 12, 2024
2 of 3 checks passed
@carletex carletex deleted the active-grants-page branch August 12, 2024 14:50
@carletex
Copy link
Contributor

Now that I'm seeing my pic I see that I missed the margin on the completed grants. Will hotfix :D

@carletex
Copy link
Contributor

92f24a2

@technophile-04 technophile-04 mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants