-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
active grants page #134
active grants page #134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @technophile-04!! At first, I thought about an admin route for this, but this makes sense too.
Just created it, it's building atm. Question: How is the new page being cached? I think we want it to be fresh all the time. |
Oh, let's add a link to the new page in /admin! (maybe on the right corner? above completed grants) |
Yeah even I had this in my mind but while tackling realised that it was already public so kept it as it.
Ohh shit nice catch! actually it was completely static : Update at 26df0c3 so get always fresh data.
Yup, update at 20448e5 : Not sure whats the best place, maybe we keep it at Header instead? and show only when admin is logged in? |
I always forget how caching works in NextJS app router. But my mental model is that if you don't do anything explicit, probably the stuff is going to be cached :D
I moved it here for now. Seems like a decent place that doesn't get in the middle. |
Now that I'm seeing my pic I see that I missed the margin on the completed grants. Will hotfix :D |
Description:
Currently we were showing full list of active grants in landing page itself in the table view. This PR's limit grants displayed on home page to 8 and then creates
/active-grant
page with cards view.Screen.Recording.2024-08-11.at.1.03.38.PM.mov