Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract's txn hash for batch actions #65

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

technophile-04
Copy link
Member

@technophile-04 technophile-04 commented Mar 6, 2024

Description

Used splitEqualETH function from the contract. In future we could add an unequal spilt function but since in mock DB the askAmount is same for all grant 0.25 it works nicely 🙌

probably Closes #56 ?

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:41am

@carletex
Copy link
Contributor

carletex commented Mar 8, 2024

This is great @technophile-04

In future we could add an unequal spilt function but since in mock DB the askAmount is same for all grant 0.25 it works nicely 🙌

You are right. I pushed this: 2230038 to add a single splitETH function where you can specify a given amount for each address. I think this is more generic and better. Could you tweak the frontend to use this new function? Sorry!


I think we should also call the contract when sending to a single user (send 50%), even if we are not splitting anything:

  • BG safe multisigs can sign the TX with the contract
  • This allow to emit an event in the contract
  • The user get the funds from the BGGrants contract (grants.buidlguidl.eth)

If we want to optimize gas, I guess we should create a new function for a single address... but let's use splitETH for now.

@carletex carletex merged commit ef9e2f0 into main Mar 14, 2024
3 checks passed
@carletex carletex deleted the contract-actions branch March 14, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/admin Multiple selection + actions on grants
2 participants