Add /api/projects endpoints
#34
Conversation
|
@swellander is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return data.map(item => ({ | ||
| id: item.id, | ||
| const response = await fetch(`${process.env.NEXT_PUBLIC_API_URL}/stub/project_ids`); | ||
| const data: Project[] = await response.json(); |
There was a problem hiding this comment.
this is a string[] no a project[]
swellander
force-pushed
the
project-id-endpoint
branch
from
d97040a
to
b6cb5a9
Compare
to services/database
which uses OSO ids
to hit new endpoints
swellander
force-pushed
the
project-id-endpoint
branch
from
b6cb5a9
to
cabdf50
Compare
swellander
changed the title
/api/stub/project_ids endpoint/api/projects endpoints
packages/firebase/seed.sample.json
Outdated
There was a problem hiding this comment.
Updated the seed sample file projects with agora projects with OSO id mappings
|
I am going to dig in to why the build is still failing. This looks good so nice work! |
There was a problem hiding this comment.
This file won't display for me due to lines 43-56 where [...data?.github, ...data?.packages]. If the project doesn't have github or packages properties then the spread operator is trying to act upon undefined causing this error:
Error: (intermediate value) is not iterable.
We should check for the existence of github and packages before using the spread operator.
I might need to reseed the production data for the build to succeed. I will give that a try when you commit the fixes I discussed in my review. |
| if (!id) return res.status(400).json({ message: "Must include project ID" }); | ||
| try { | ||
| const projectDetail = await getProjectById(id); | ||
| const projectDetailDto = convertProjectToDto(projectDetail); |
There was a problem hiding this comment.
The request from the project page needs more than the dto version. It needs the whole Project.
|
@swellander #46 has the seed data changes for projects covered. If it gets merged in before this then you can remove your changes to |
|
Closing this since all the relevant changes were absorbed by #46. Thanks for your help with this @swellander. |
Description
Creates the following endpoints to fetch project data from our db:
/api/projectsto return a list of all projects (closes API Definition [projects GET] #37)/api/projects/detail/{ID}to return a single project (closes API Definition [ProjectById] #38)/api/projects/idsto return a flat list of all project IDs for our static page generation