[pending]Bera #144
Open
[pending]Bera #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangbinjie
reviewed
May 17, 2024
| import { MenuItem, Select, SelectChangeEvent } from '@mui/material'; | ||
| interface TSelectProps { | ||
| defaultValue: string; | ||
| options: string[]; |
There was a problem hiding this comment.
options 的类型最好是 { value, label }，不然无法满足后面的需求
huangbinjie
reviewed
May 17, 2024
| @@ -87,10 +87,11 @@ export async function unstake(address: string, amount: number) { | |||
| amount: BigNumber(amount).times(SHARE_UNIT_MODIFIER).toFixed(), | |||
| }); | |||
| } | |||
| export async function transfer(address: string, amount: string) { | |||
| export async function transfer(address: string, amount: string, token?: string) { | |||
huangbinjie
reviewed
May 17, 2024
| @@ -52,7 +52,7 @@ const useGlobalStore = create<GlobalStoreProps>()( | |||
| }); | |||
| }, | |||
| userVote: null, | |||
| chain: Chain.Arb, | |||
| chain: Chain.Bera, | |||
There was a problem hiding this comment.
感觉把 chain 做成环境变量好点把，不然产品找你要 Arb 版本我们还得改源码。。
huangbinjie
reviewed
May 17, 2024
| @@ -310,7 +314,17 @@ const BuyModal = ({ onClose }: BuyModalProps) => { | |||
| <div className="flex items-center space-x-1"> | |||
| <Icon1 /> | |||
| <span className="text-2xl font-bold"> | |||
| <NumberDisplayer text={total} loading={loadingPrice || loadingPirceAfterFee} /> | |||
| <NumberDisplayer | |||
| text={new BigNumber(priceAfterFee).toFixed()} | |||
There was a problem hiding this comment.
这里为什么要new 以下来着，之前是 total 现在改成 priceAfterFee 是预期的吗
huangbinjie
reviewed
May 17, 2024
| <TSelect | ||
| defaultValue={Token.WETH} | ||
| options={[Token.WETH, Token.Bera]} | ||
| onChange={(x) => {}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.