Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 0 as an undefined index #1

Open
wants to merge 2,384 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
2384 commits
Select commit Hold shift + click to select a range
64f629d
update WasIHaveRPCSent to check multiple topic IDs with multiple mess…
kc1116 Jul 11, 2023
c66755b
fix mock bug
Jul 11, 2023
67b4390
add error description for newSource()
Jul 11, 2023
36c7855
Merge pull request #4543 from onflow/khalil/1897-ihave-rpc-tracker
kc1116 Jul 11, 2023
1f1a341
revert LRUEjector and remove random ejection fallback
Jul 12, 2023
183ce49
use fatal logging when system randomness fails
Jul 12, 2023
a2aa5d7
Merge branch 'master' into UlyanaAndrukhiv/3138-rest-api-on-observers
UlyanaAndrukhiv Jul 12, 2023
398b49c
add component and worker pool to rpc sent tracker
kc1116 Jul 12, 2023
e373b01
update all usages of NewGossipSubMeshTracer
kc1116 Jul 12, 2023
2a83452
update rpc sent tracker test
kc1116 Jul 12, 2023
14ef77d
Update rpc_sent_tracker.go
kc1116 Jul 12, 2023
6ddbb2b
auto update to onflow/cadence v0.39.14
SupunS Jul 11, 2023
82d6e5f
Update to flow-go-sdk@v0.41.9 version
SupunS Jul 12, 2023
a2f5f4b
update grep command to work for different grep versions and remove tmate
Jul 12, 2023
e38c31e
track last highest iHaves size
kc1116 Jul 12, 2023
117fcc0
Verification Node documentation (#4528)
yhassanzadeh13 Jul 12, 2023
20b917e
reset LastHighestIhavesSent every 1 minute
kc1116 Jul 12, 2023
c1e13c9
Merge branch 'master' into khalil/1899-async-rpc-sent-tracker
kc1116 Jul 12, 2023
f19483f
Update rpc_sent_tracker_test.go
kc1116 Jul 12, 2023
672df92
Merge branch 'khalil/1899-async-rpc-sent-tracker' of github.com:onflo…
kc1116 Jul 12, 2023
ac19f5f
Update network/alsp/manager/manager_test.go
kc1116 Jul 12, 2023
c924c1c
Update network/alsp/manager/manager_test.go
kc1116 Jul 12, 2023
ca4fc5b
Update network/alsp/manager/manager_test.go
kc1116 Jul 12, 2023
f67f007
Update network/alsp/manager/manager_test.go
kc1116 Jul 12, 2023
07796e9
Update manager_test.go
kc1116 Jul 12, 2023
8ca997d
Merge branch 'master' into UlyanaAndrukhiv/3138-rest-api-on-observers
UlyanaAndrukhiv Jul 14, 2023
fd4ffaf
Merge branch 'master' into bootstrapping-views
janezpodhostnik Jul 14, 2023
8e21991
Merge branch 'master' into tarak/go1.20-rand-prep
tarakby Jul 14, 2023
72b4db9
Merge pull request #4052 from onflow/tarak/go1.20-rand-prep
tarakby Jul 14, 2023
6228e63
Fix missing events in uploaded block data
fxamacker Jul 14, 2023
6fe26d1
Merge branch 'master' into fxamacker/fix-incomplete-events-in-gcp-upl…
fxamacker Jul 14, 2023
f1d5a06
Merge pull request #4562 from onflow/fxamacker/fix-incomplete-events-…
fxamacker Jul 14, 2023
f88f097
Go 1.20
SaveTheRbtz Feb 8, 2023
0bd284c
Update golangci-lint
Kay-Zee Feb 8, 2023
51b646b
Refactor badger cache and all the client code to use generics instead…
nozim Jul 16, 2023
9089a1e
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 17, 2023
8455b98
Merge branch 'master' into UlyanaAndrukhiv/3138-rest-api-on-observers
UlyanaAndrukhiv Jul 17, 2023
52c701e
Merge branch 'master' into UlyanaAndrukhiv/4217-single-gRPC-port
UlyanaAndrukhiv Jul 17, 2023
02be088
Fixed remarks
Guitarheroua Jul 17, 2023
2b9e8ee
Merge #4550
bors[bot] Jul 17, 2023
81bc2d8
update more go1.20 deprecated functions
Jul 17, 2023
79c011b
remove math/rand.Read calls
Jul 17, 2023
8bd2eef
Merge branch 'master' into petera/rename-without-netgo-tag
peterargue Jul 17, 2023
e26bc28
Merge pull request #4548 from onflow/petera/rename-without-netgo-tag
peterargue Jul 17, 2023
ef86705
remove unused function
Jul 17, 2023
6b9cce5
use assert.Zero
Jul 17, 2023
edc0bb6
Merge branch 'master' into 3932-refactor-badger-cache
nozim Jul 18, 2023
e2547b6
Added evicting cache client test
Guitarheroua Jul 18, 2023
dbe364c
Change config from pointer to value
Guitarheroua Jul 18, 2023
1b2e6df
Removed unused field
Guitarheroua Jul 18, 2023
da69a05
Fixed remarks
Guitarheroua Jul 18, 2023
cc90ff9
Fixed remarks
Guitarheroua Jul 18, 2023
aa528ad
Merge branch 'master' into bootstrapping-views
janezpodhostnik Jul 17, 2023
e3411ef
Merge pull request #4536 from onflow/bootstrapping-views
janezpodhostnik Jul 18, 2023
a2aaf27
Merge branch 'master' of github.com:Guitarheroua/flow-go into guitarh…
Guitarheroua Jul 18, 2023
0af1f45
Merge branch 'master' into tarak/go1.20
tarakby Jul 18, 2023
3ea1fd4
Fixed issue with sample after merge.
Guitarheroua Jul 18, 2023
80132f9
Fixed issue with all nodes unavailable.
Guitarheroua Jul 18, 2023
f654460
Make timeouts shorter in cf tests.
Guitarheroua Jul 18, 2023
bc369b2
Update network/p2p/tracer/gossipSubMeshTracer.go
kc1116 Jul 18, 2023
a7e305a
Fixed integration test.
Guitarheroua Jul 18, 2023
7b52ab1
encapsulate tracer-related config parameters
kc1116 Jul 18, 2023
b82247d
Update config/default-config.yml
kc1116 Jul 18, 2023
b8c72cc
Update network/p2p/p2pconf/gossipsub.go
kc1116 Jul 18, 2023
4e31202
Merge branch 'khalil/1899-async-rpc-sent-tracker' of github.com:onflo…
kc1116 Jul 18, 2023
bea0fff
Update gossipsub.go
kc1116 Jul 18, 2023
fb08d0d
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 18, 2023
7e9e885
Merge branch 'guitarheroua/2833-conn-pool-evictions-cause-conn-failur…
Guitarheroua Jul 18, 2023
e7dc893
[Networking] Handling iHave overpromising part-1 (#4556)
yhassanzadeh13 Jul 18, 2023
a97a02a
Merge branch 'master' into tarak/go1.20
tarakby Jul 18, 2023
1a5b5dc
Merge branch 'master' into guitarheroua/3129-access-add-circuit-breaker
Guitarheroua Jul 18, 2023
8aa1593
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 18, 2023
163cee6
Merge branch 'guitarheroua/2833-conn-pool-evictions-cause-conn-failur…
Guitarheroua Jul 18, 2023
4bacc83
internally construct metrics for the tracker
kc1116 Jul 18, 2023
87c07e0
remove AddWorkers
kc1116 Jul 18, 2023
1338279
change debug -> info
kc1116 Jul 18, 2023
bec095c
rename trackRPC -> trackableRPC
kc1116 Jul 18, 2023
119f946
rename RPCSent -> Track
kc1116 Jul 18, 2023
23c6cfe
document errors as benign
kc1116 Jul 18, 2023
e1c57c6
return error if submit returns false
kc1116 Jul 18, 2023
344b30f
rename rpcSent -> rpcSentWorkerLogic
kc1116 Jul 18, 2023
e6a0a33
add lastUpdate to lastHighestIHaveRPCSize tracking
kc1116 Jul 18, 2023
06575d4
Merge branch 'master' into khalil/1899-async-rpc-sent-tracker
kc1116 Jul 18, 2023
640f9bf
add KeyNetworkingSecurity when err returned during tracking
kc1116 Jul 18, 2023
1c55cf1
Merge branch 'master' into 1898-slashing-violations-consumer-alsp-int…
kc1116 Jul 18, 2023
fbd8446
Added test TestExecutionEvictingCacheClients
Guitarheroua Jul 18, 2023
2249991
[Access] Update REST metrics to use route name for all types
peterargue Jul 19, 2023
9682381
Merge pull request #4549 from onflow/1898-slashing-violations-consume…
kc1116 Jul 19, 2023
e67bcc9
Merge branch 'master' into tarak/go1.20
tarakby Jul 19, 2023
1aff7f9
Merge #4563
bors[bot] Jul 19, 2023
a2e8fb1
[Networking] Handling iHave broken promises (and part-2 of overpromis…
yhassanzadeh13 Jul 19, 2023
f2bc373
use new interface EntropyProvider in FVM instead of protocol.Snapshot
Jul 19, 2023
b8cf688
merge master branch
Jul 19, 2023
29deae0
update entropy provider mock file
Jul 19, 2023
4c643c8
Merge branch 'master' into guitarheroua/3129-access-add-circuit-breaker
Guitarheroua Jul 19, 2023
3412d68
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 19, 2023
c6624d2
ScriptExecutor should always populate env values even when the script…
m-Peter Jul 19, 2023
c7d1f07
Merged with master
UlyanaAndrukhiv Jul 19, 2023
43bea66
Return add to retrive connection.
Guitarheroua Jul 19, 2023
13c49c8
Merge branch 'guitarheroua/2833-conn-pool-evictions-cause-conn-failur…
Guitarheroua Jul 19, 2023
4e4ca6c
Merge branch 'master' into khalil/1899-async-rpc-sent-tracker
kc1116 Jul 19, 2023
574fb22
Append both errors in executeScript() with multierror
m-Peter Jul 19, 2023
7c2b340
Merge pull request #4498 from onflow/tarak/env-safe-random
tarakby Jul 19, 2023
1987e60
require url mapper in constructor
peterargue Jul 19, 2023
a7634ff
fix error return
peterargue Jul 19, 2023
811f83b
spike to improve locking in grpc connection factory
peterargue Jul 19, 2023
e09ba32
remove cache from factory
peterargue Jul 19, 2023
1aa6e3d
Add test cases for asserting the population of ProcedureOutput from s…
m-Peter Jul 20, 2023
248c4e9
Revert unnecessary changes
Guitarheroua Jul 20, 2023
b62727f
Merge branch 'master' into UlyanaAndrukhiv/4217-single-gRPC-port
UlyanaAndrukhiv Jul 20, 2023
da821bc
Fixed test case
Guitarheroua Jul 20, 2023
1237a59
Merge branch 'master' into script-executor-populate-env-values
m-Peter Jul 20, 2023
ac8c8b1
Implemented limitation for scripts execution nodes
Guitarheroua Jul 20, 2023
d9575a6
Merge branch 'master' of github.com:Guitarheroua/flow-go into guitarh…
Guitarheroua Jul 20, 2023
c0b4436
Updated according to comments
UlyanaAndrukhiv Jul 20, 2023
3ed6741
Fixed if statement
Guitarheroua Jul 20, 2023
b779edf
Added check for argument
Guitarheroua Jul 20, 2023
ea7748f
Added part of updates according to comments
UlyanaAndrukhiv Jul 20, 2023
77ff167
Merged with master
UlyanaAndrukhiv Jul 20, 2023
da22beb
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 20, 2023
6a857fe
Merge branch 'petera/example-conn-factory-refactor' of github.com:onf…
Guitarheroua Jul 20, 2023
06c67f2
Upgrade Emulator
janezpodhostnik Jul 20, 2023
de05263
Merge branch 'master' into petera/fix-rest-metrics-take3
peterargue Jul 20, 2023
ae9c109
Refactor connection factory
Guitarheroua Jul 20, 2023
85b17f9
Added comments to new components
Guitarheroua Jul 20, 2023
48cae42
Merge branch 'guitarheroua/2833-conn-pool-evictions-cause-conn-failur…
Guitarheroua Jul 20, 2023
1122b8c
removed unnecessary changes
Guitarheroua Jul 20, 2023
fb4e43f
removed unnecessary changes
Guitarheroua Jul 20, 2023
2782d45
Merge pull request #4575 from onflow/janez/upgrade-emulator
janezpodhostnik Jul 20, 2023
e510954
Merge branch 'master' into UlyanaAndrukhiv/4217-single-gRPC-port
UlyanaAndrukhiv Jul 20, 2023
4d37538
Merged with master
UlyanaAndrukhiv Jul 20, 2023
c1347be
Linted
UlyanaAndrukhiv Jul 20, 2023
435c8ff
Merge branch 'master' into petera/fix-rest-metrics-take3
peterargue Jul 20, 2023
806456f
Merge pull request #4571 from onflow/petera/fix-rest-metrics-take3
peterargue Jul 20, 2023
8bbacfc
Merge branch 'master' into guitarheroua/3129-access-add-circuit-breaker
Guitarheroua Jul 20, 2023
226f053
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 20, 2023
e96b90e
Merge branch 'master' into UlyanaAndrukhiv/4217-single-gRPC-port
UlyanaAndrukhiv Jul 20, 2023
7dc921b
Apply suggestions from code review
Guitarheroua Jul 20, 2023
384968a
change error terminator argument type
Guitarheroua Jul 20, 2023
36869d1
Merge branch 'master' of github.com:UlyanaAndrukhiv/flow-go into Ulya…
UlyanaAndrukhiv Jul 20, 2023
7faa9e7
Fixed last commit
UlyanaAndrukhiv Jul 20, 2023
999eb9b
add lock for last size and last size update
kc1116 Jul 20, 2023
65bc05b
remove topic ID from entity ID
kc1116 Jul 20, 2023
7c5daef
add test cases for concurrent tracking and duplicate RPC tracking
kc1116 Jul 20, 2023
c1d3b2e
remove add workers func
kc1116 Jul 20, 2023
d5e7b22
Merge branch 'master' into khalil/1899-async-rpc-sent-tracker
kc1116 Jul 20, 2023
9fa4f4a
Merge branch 'master' into 3932-refactor-badger-cache
Kay-Zee Jul 20, 2023
fe02ec9
Merge branch 'master' into script-executor-populate-env-values
janezpodhostnik Jul 21, 2023
ca27c87
Merge #4572
bors[bot] Jul 21, 2023
26b435e
Updated according to comments, added rest metrics to observer node
UlyanaAndrukhiv Jul 21, 2023
d47cc09
Merge branch 'master' into UlyanaAndrukhiv/3138-rest-api-on-observers
UlyanaAndrukhiv Jul 21, 2023
d6eb702
Merge branch 'master' into UlyanaAndrukhiv/4217-single-gRPC-port
UlyanaAndrukhiv Jul 21, 2023
cc4c03c
Fixed broken test
Guitarheroua Jul 21, 2023
26ef6f7
Merge branch 'master' into guitarheroua/3129-access-add-circuit-breaker
Guitarheroua Jul 21, 2023
5240b3b
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 21, 2023
695ff8c
Fixed review remarks
Guitarheroua Jul 21, 2023
3f3c15f
Merge pull request #4411 from UlyanaAndrukhiv/UlyanaAndrukhiv/4217-si…
durkmurder Jul 21, 2023
c7c05b9
Merged with master
UlyanaAndrukhiv Jul 21, 2023
b53dd43
Merge pull request #4499 from UlyanaAndrukhiv/UlyanaAndrukhiv/3138-re…
peterargue Jul 21, 2023
8644def
Merge branch 'master' of github.com:Guitarheroua/flow-go into guitarh…
Guitarheroua Jul 21, 2023
eb6b627
Fixed conflicts
Guitarheroua Jul 21, 2023
30ac5aa
Apply suggestions from code review
Guitarheroua Jul 21, 2023
82f8cba
Fixed review remarks
Guitarheroua Jul 21, 2023
0d5a2c4
Fixed integrarion test. Removed timeouts as it is invalid check there.
Guitarheroua Jul 21, 2023
ec9fb75
Merge branch 'master' of github.com:Guitarheroua/flow-go into guitarh…
Guitarheroua Jul 21, 2023
3bc333b
Merge branch 'master' into 3932-refactor-badger-cache
nozim Jul 23, 2023
bb8a8b0
Merge branch '3932-refactor-badger-cache' of github.com:nozim/flow-go…
nozim Jul 23, 2023
554071e
Generic related refactoring based on code review feedback
nozim Jul 23, 2023
b4c749c
CHanged timeouts
Guitarheroua Jul 24, 2023
359c8ce
Added sample benchmark of cache test generic vs interface with sample…
nozim Jul 24, 2023
46d10fb
Removed work around
Guitarheroua Jul 24, 2023
abf501b
Remove benchmark file, refactor benchmark test
nozim Jul 25, 2023
f90bea0
Update go.mod, remove benchmark files
nozim Jul 25, 2023
6a4e69b
Fix imports
nozim Jul 25, 2023
ab2ee74
Update rpc_sent_tracker.go
kc1116 Jul 25, 2023
41f7d5c
Update rpc_sent_tracker.go
kc1116 Jul 25, 2023
f1b7e5c
Update gossipSubMeshTracer_test.go
kc1116 Jul 25, 2023
2f95232
Merge branch 'master' into khalil/1899-async-rpc-sent-tracker
kc1116 Jul 25, 2023
3a8139b
Merge pull request #4553 from onflow/khalil/1899-async-rpc-sent-tracker
kc1116 Jul 25, 2023
f7c7116
Merge branch 'master' into guitarheroua/2833-conn-pool-evictions-caus…
Guitarheroua Jul 25, 2023
0607ed2
Merge pull request #4534 from Guitarheroua/guitarheroua/2833-conn-poo…
peterargue Jul 26, 2023
e39b63f
Handle code review feedback, remove benchmark file, comments and rena…
nozim Jul 26, 2023
2ee71bd
Merge branch 'master' into 3932-refactor-badger-cache
nozim Jul 26, 2023
9d68658
Fix goimports
nozim Jul 26, 2023
4dc66e6
Merge branch 'master' of github.com:Guitarheroua/flow-go into guitarh…
Guitarheroua Jul 27, 2023
3f3da35
Merge pull request #4565 from nozim/3932-refactor-badger-cache
durkmurder Jul 27, 2023
4f572a2
FVM flaky tests fix
janezpodhostnik Jul 25, 2023
86d1724
Merge #4581
bors[bot] Jul 27, 2023
02a6ab4
Merge branch 'master' into guitarheroua/3129-access-add-circuit-breaker
Guitarheroua Jul 27, 2023
731a26c
Fixed remarks
Guitarheroua Jul 27, 2023
f66dd13
Merge branch 'guitarheroua/3129-access-add-circuit-breaker' of github…
Guitarheroua Jul 27, 2023
2aca88e
Merge pull request #4496 from Guitarheroua/guitarheroua/3129-access-a…
durkmurder Jul 28, 2023
7623ce8
Merge #4546
bors[bot] Jul 28, 2023
e0527bc
add workflow to validate git tags
janezpodhostnik Jul 11, 2023
9d1c066
make the node fail to start on invalid version
janezpodhostnik Jul 11, 2023
115432e
Merge #4552
bors[bot] Jul 28, 2023
b597288
Added size to a list struct, removed some isUndefined() and setUndefi…
Jun 5, 2023
6bc29b8
Removed some more checks for undefined
Jun 5, 2023
b135031
Milestone: Removed isUndefined from code, tests do pass
Jun 5, 2023
50ad010
Milestone: setUndifined is removed
Jun 5, 2023
0235526
Removed +1 amd -1 shifts of index
Jun 5, 2023
3153368
Removed setPoolIndex
Jun 9, 2023
bc768cb
Cleaned up from superfluous comments
Jun 9, 2023
0d6628f
Fixed tests
Jun 9, 2023
640a689
Refactored methods to lists
Jun 9, 2023
c532cfb
Improve method names
Jun 9, 2023
286c00d
Improve method names and saved
Jun 9, 2023
e06fb76
Refactored out connect3
Jun 9, 2023
cfbf222
Refactored all lit methods
Jun 9, 2023
a168d69
Removed the need for pool index
Jun 9, 2023
9a6c363
Removed poll index file
Jun 9, 2023
88dc3b9
Removed obsolet comments
Jun 9, 2023
d2587e8
removed obsolete line
Jun 9, 2023
92aa83f
removed superfluous comment
Jun 9, 2023
e8bd105
fixed typo
Jun 9, 2023
547c133
Added a unit test for linked list
Jun 12, 2023
f081841
Fixed comments
Jun 12, 2023
4dc4023
Improved comment
Jun 12, 2023
1b78ad0
Added a unit test for append
Jun 16, 2023
51ae752
Implemented -1 as an invalid index-a
Jun 21, 2023
9f363dc
Put back all checks for the invalid index
Jun 21, 2023
9612f30
Added a consistency list check
Jun 21, 2023
3224d2d
Improved documentation
Jun 21, 2023
9503bd6
Added more checks for pool consictensy
Jun 21, 2023
9c8e431
Changed undefined value to max uint
Jun 22, 2023
418a33d
Added remove add tests
Jun 23, 2023
5721649
Changed variable name
Jun 23, 2023
2c2fd7b
Added some go doc descriptions
Jun 23, 2023
e126956
Fixed comments and import
Jun 23, 2023
f3d0bae
Fixed variable names
Jun 23, 2023
5e7c93c
Add a comment to invalid index
Jun 23, 2023
dbb1a06
Intoduced stateUsed and stateFree
Jun 30, 2023
08ca9a1
Modified test to include randoim operations
Jun 30, 2023
ff86508
Removed leftover debug code
Jun 30, 2023
85db735
Improved comments
Jul 2, 2023
f9a1e68
Refactored test
Jul 7, 2023
2543fc4
Added check in remove entity
Jul 7, 2023
5952770
Removed getStateFromType
Jul 7, 2023
9c8ea50
Removed asset test files
Jul 7, 2023
b629dbc
Formatted comments
Jul 7, 2023
90ebef1
fixed compilation error
Jul 7, 2023
423f085
Fixed typo
Jul 7, 2023
2cce08f
Improved test
Jul 12, 2023
65fe54a
Apply suggestions
Jul 14, 2023
f198a64
Minor modifications
Jul 14, 2023
167f5de
Minor clean-up
Jul 17, 2023
c366b7d
Rebased changes, replaced rand
Jul 19, 2023
772655e
minor clean-up
Jul 19, 2023
87599c8
minor clean-up2
Jul 19, 2023
ae190fc
Added godoc to hero pool constr
Jul 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed typo
Boris Kozlov authored and Boris Kozlov committed Jul 31, 2023
commit 423f0854e28ba99d67f854f4cc6604ad00070af3
2 changes: 1 addition & 1 deletion module/mempool/herocache/backdata/heropool/pool.go
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ const (
// EIndex is data type representing an entity index in Pool.
type EIndex uint32

// InvalidIndex is used when a link doesnt point anywhere, in other words it is an equivalent of a nil adress.
// InvalidIndex is used when a link doesnt point anywhere, in other words it is an equivalent of a nil address.
const InvalidIndex EIndex = math.MaxUint32

// A type dedicated to describe possible states of placeholders for entities in the pool.