Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): allow editing symbols in the context of a parent page pr… #3736

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

teleaziz
Copy link
Collaborator

@teleaziz teleaziz commented Nov 15, 2024

…eview url

Allow editing symbols when the preview URL is the parent page.

Makes it easier to tweak symbols by letting you edit them directly where they're being used, rather than having to find and open the symbol file separately. Way more convenient for users

@teleaziz teleaziz requested a review from a team as a code owner November 15, 2024 15:24
@teleaziz teleaziz requested review from samijaber and removed request for a team November 15, 2024 15:24
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: ebbb5a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teleaziz I don't fully follow what this enables. can you expand on what you mean by "allows editing of symbols in the context of a parent page"? a loom showing how this works would be great

@samijaber
Copy link
Contributor

I see the other PR with the loom now. Is it possible to always include gen2 SDKs when making improvements like this? It's much easier to maintain parity by updating both at the same time, otherwise gen2 SDKs will always be playing catchup with all these features missing from them.

@teleaziz
Copy link
Collaborator Author

@samijaber Thanks, but I want to keep this PR focused on fixing the React SDK user-blocking issue. Let's track gen2 SDK improvements separately - I'm not sure Gen2 has the same issue here since the implementations has a different approach.

@teleaziz teleaziz requested a review from samijaber November 15, 2024 18:30
@teleaziz teleaziz merged commit bf8d783 into BuilderIO:main Nov 19, 2024
47 of 48 checks passed
@teleaziz teleaziz deleted the symbol-parent-preview branch November 19, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants