Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hashbang issue on Windows by upgrading pkgroll to 1.11+ #68

Merged

Conversation

tlaukkanen
Copy link
Contributor

pkgroll v1.9 had an issue as it was not adding the hashbang to generated .mjs file on Windows which caused the binary not to start with micro-agent when installed with npm install -g. pkgroll provided a fix for this in v1.11 as seen on privatenumber/pkgroll#40

The fix was applied here by installing latest v1.x release of pkgroll with npm install --save-dev pkgroll@1.11.1

cli.mjs before the fix with npm run build on Windows:

import { command, cli } from 'cleye';
import { dim, red, gray, green, blue, yellow } from 'kolorist';

...and with more recent pkgroll version as provided in this pull request:

#!/usr/bin/env node
import { command, cli } from 'cleye';
import { dim, red, gray, green, blue, yellow } from 'kolorist';
...

@steve8708 steve8708 merged commit 85fcd2b into BuilderIO:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants