upgrade to Rust 2018 + bump MSRV to Rust 1.41 + deprecate byte class and premultiply options #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options aren't really carrying their weight. In a future release, aho-corasick will make both options enabled by default all the time with the impossibility of disabling them. The main reason for this is that these options require a quadrupling in the amount of code in this crate. While it's possible to see a performance hit when using byte classes, it should generally be very small. The improvement, if one exists, just doesn't see worth it. Please see #57 for more discussion. This is meant to mirror a similar decision occurring in regex-automata: BurntSushi/regex-automata#7.
This is in line with similar changes to the regex and memchr crates: BurntSushi/memchr#82 and rust-lang/regex#767
We also use the 'std' feature in lieu of the 'use_std' feature, which was deprecated quite some time ago.
|
This PR is on crates.io in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in line with similar PRs in the
memchrandregexcrates:Basically, we do what it says on the tin. And we deprecate the options for disabling byte classes and premultiplication. Instead, we will eventually make them always-on. See #57 for more on that.