Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Rust 2018 + bump MSRV to Rust 1.41 + deprecate byte class and premultiply options #75

Merged
merged 6 commits into from
Apr 30, 2021

Conversation

BurntSushi
Copy link
Owner

This PR is in line with similar PRs in the memchr and regex crates:

Basically, we do what it says on the tin. And we deprecate the options for disabling byte classes and premultiplication. Instead, we will eventually make them always-on. See #57 for more on that.

These options aren't really carrying their weight. In a future release,
aho-corasick will make both options enabled by default all the time with
the impossibility of disabling them. The main reason for this is that
these options require a quadrupling in the amount of code in this crate.

While it's possible to see a performance hit when using byte classes, it
should generally be very small. The improvement, if one exists, just
doesn't see worth it.

Please see #57 for more
discussion.

This is meant to mirror a similar decision occurring in regex-automata:
BurntSushi/regex-automata#7.
This is in line with similar changes to the regex and memchr crates:
BurntSushi/memchr#82
and
rust-lang/regex#767
We also use the 'std' feature in lieu of the 'use_std' feature, which
was deprecated quite some time ago.
@BurntSushi BurntSushi merged commit 2281bf6 into master Apr 30, 2021
@BurntSushi BurntSushi deleted the ag/rust-2018 branch April 30, 2021 23:35
@BurntSushi
Copy link
Owner Author

BurntSushi commented May 1, 2021

This PR is on crates.io in aho-corasick 0.7.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant