Resolve clippy warnings in normal build #157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix a few cases where byteorder invokes undefined behavior (caught by clippy) by dereferencing a possibly unaligned pointer (see here).
While I was doing that, I additionally cleaned up the other clippy warnings around
the use of theusingtry!
macro andptr::offset
instead ofptr::add
.IMO the only important changes here are the fixes to the UB, so I'm happy to revert the other changes and open a different PR with them (or just forget about them), if you'd prefer.
Edit: I should have looked at the Travis config - looks like 1.12 is the minimum Rust version, so I've reverted my proposed changes around use of
try!
.