Transition from wasm32-wasi to wasm32-wasip1, fix clippy lint #158
Conversation
purplesyringa
force-pushed
the
clippy
branch
4 times, most recently
from
5be1453
to
d29619c
Compare
|
The transition to But I don't have Clippy enabled for a reason. There are a lot of lints that I don't always agree with. Even in this PR, I see some changes I like and some I don't. I'm not sure I really want to spend the time going through all of them to be honest. I have a long-standing TODO item to go through the Clippy lints, select the ones I like and then use them in my various Rust projects. But it hasn't been a priority for me. |
|
How about I apply the least contentious clippy lints for now? I'd like to:
This alone would remove a significant percentage of clippy lints. |
|
I agree with the third bullet point, but not the first two. For (1), my line wrapper doesn't conform to the style that Clippy wants, so that would be annoying for me. For (2), I don't have a super strong opinion, but I actually like the status quo better. |
|
I see. I think I'll apply the 3rd bullet then, and whitelist other lints. That should be no worse than status quo and might actually catch bugs. |
|
Please don't include Clippy in CI. |
|
Sure, I'll get to it soon. What is the rationale by the way? |
|
I have reduced the PR to just wasm transition, the core:: replacement, and a bunch of clippy allows. Is that sufficient? |
I think I explained why here: #158 (comment)
No. Please remove Clippy from CI. I've already said that I have a TODO to go through Clippy lints and pick the ones I want. But I haven't done it yet, and until then, I don't want Clippy in CI. |
|
Oh, wait, I must have misunderstood you. I assumed you don't want clippy in CI but still want it outside CI. That was odd phrasing. Fixed. |
purplesyringa
changed the title
This should hopefully ease maintenance of the crate and enable easier wide refactoring.
Also, the
wasm32-wasitarget was renamed towasm32-wasip1, and the former is going to be removed soon, so I fixed that.