-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--vimgrep reports incorrect column number #18
Comments
And also, rg claims they are 1-based indexed:
|
All set. It should be fixed in the next release. I'm going to try to knock off a few bugs before cutting one. |
Cool, thanks! Any chance of getting a linux build on the next release too? I noticed there isn't one for 0.1.17... |
@latortuga Absolutely! It's supposed to happen automatically, but either Travis or rustup.rs hiccuped last time: https://travis-ci.org/BurntSushi/ripgrep/jobs/162231880 |
ripgrep was documented to do 1-based indexing, so this is a bug and not a breaking change. Fixes BurntSushi#18
The column reported is off-by-one. You can see this here:
https://github.com/BurntSushi/ripgrep/blob/master/tests/tests.rs#L577
The W in "Watsons" is column 16, vim starts column counting with 1.
The text was updated successfully, but these errors were encountered: