Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--vimgrep reports incorrect column number #18

Closed
latortuga opened this issue Sep 23, 2016 · 4 comments
Closed

--vimgrep reports incorrect column number #18

latortuga opened this issue Sep 23, 2016 · 4 comments

Comments

@latortuga
Copy link

The column reported is off-by-one. You can see this here:

https://github.com/BurntSushi/ripgrep/blob/master/tests/tests.rs#L577

The W in "Watsons" is column 16, vim starts column counting with 1.

@BurntSushi
Copy link
Owner

And also, rg claims they are 1-based indexed:

    --column
        Show column numbers (1 based) in output. This only shows the column
        numbers for the first match on each line. Note that this doesn't try
        to account for Unicode. One byte is equal to one column.

@BurntSushi
Copy link
Owner

All set. It should be fixed in the next release. I'm going to try to knock off a few bugs before cutting one.

@latortuga
Copy link
Author

Cool, thanks! Any chance of getting a linux build on the next release too? I noticed there isn't one for 0.1.17...

@BurntSushi
Copy link
Owner

@latortuga Absolutely! It's supposed to happen automatically, but either Travis or rustup.rs hiccuped last time: https://travis-ci.org/BurntSushi/ripgrep/jobs/162231880

amsharma91 added a commit to amsharma91/ripgrep that referenced this issue Sep 27, 2016
ripgrep was documented to do 1-based indexing, so this is a bug and not
a breaking change.

Fixes BurntSushi#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants