-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify color setting of column number #377
Comments
@ShikChen Out of curiosity, what do you use the column information for? |
I use it for vim, which needs the column information to jump into exact location. The above statement is also true for option |
@ShikChen Sorry, I wasn't clear. Color information is for humans. What do you use the column information for? I understand that automated tools may read it to do useful things, but automated tools don't need colors. |
But I will see the column information in the UI of fzf.vim, if I want to jump with exact location. When the matching line starts without indent (white spaces), my eyes cannot easily parse boundary between the column number and matching line, especially when that line is starting with numbers. I agree that most of time we don't need line/column numbers. But it's still possible that someone is manipulating tabular data like csv, and need line/column information to distinguish between multiple matches. I can understand if you decide not to add color to column number. The default search tool in fzf is Ag, which doesn't support it either. Nobody complains about that so maybe I am too sensitive. Inspired from your comment, now I have some vimscripts that hiding the line/column part in fzf. |
FWIW, I do actually think line numbers are useful to be able to read because it helps orient our minds to where something is in a file (and possibly relative to other things as well). But column numbers seem less useful since lines are generally pretty short and the matches themselves are highlighted with color. I'll leave this open for now and mull on it some more. |
I found another scenario that I want the column number recently, although it's a little complex and weird. I have mapped a hotkey in vim to search the current word under the cursor in ripgrep with fzf, and I can interactively filter the results in fzf. I sometimes use the column number as filter. For example, when tracing the code of Bash, I use the column number |
@kpp That is interesting, and I think I buy that use case. However, if |
How about |
Seems contrived to me. |
How about |
@BurntSushi An options is to reset column color by default, but let users to control it if they want to. |
Currently (0.4.0) the
--colors
option only supports types path, line and match. There is no way to specify the color of column number now. So when using with--column
, the column part is uncolored and has the same style of matching line, which is a little unpleasant.The text was updated successfully, but these errors were encountered: