-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage with vim/neovim and fzf.vim #81
Comments
You mean the missing line numbers? If the output is not to a tty the parameter for line numbers -n has to be explicitly specified. |
Yes, it is intentional. When searching at a tty, line numbers, headings and colors are enabled by default. Otherwise, the default format is the same as I otherwise don't know what the problem is here. Could you please describe it in more detail? |
I see, so then it's not a problem. The issue we have is that the output of rg (0.1.17) is not captured by :echo system('ag foo')
:echo system('grep foo *')
:echo system('rg foo') EDIT: ag foo < /dev/null
grep foo * < /dev/null
rg foo < /dev/null |
I think
I bet this is the same bug that's being seen in #35. |
Hooray, this is indeed a dupe of #35! Fixing this fixes that too. |
Weird. Github didn't close this. Fixed in ab0d1c1. |
So just to clarify does Going of #35..? Cheers. |
@CrashyBang I don't think the problem has actually been explained to me, but I imagine you'd want |
Hey @BurntSushi okay sweet will go over as soon as I am home from work will let you know how it goes hoping to do a write up on medium |
@CrashyBang glad to hear it! Please send a link over if you do that write up. :-) (I'd also be happy to read a draft.) |
Hey @BurntSushi write up here: https://medium.com/@crashybang/supercharge-vim-with-fzf-and-ripgrep-d4661fc853d2 sorry wanted to get it up but still making tweaks if needed. |
@CrashyBang I would advise against suggesting |
Hey @junegunn noted and removed :). Otherwise it is okay? |
If no paths are given to ripgrep, only read from stdin if it's a file or a FIFO. In particular, if something like `rg foo < /dev/null` is used, then don't try to read from stdin. Fixes BurntSushi#35, BurntSushi#81
I am trying to set this up with fzf.vim and as per this comment
rg
does not seem to currently work.I was hoping you would have some insight into this?
Cheers.
The text was updated successfully, but these errors were encountered: