-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching stops when an unreadable file is encountered #98
Comments
Really? I can't reproduce it. I tried to be pretty careful about not falling for this trap. Here's a test case that works on my end. Could you try to produce something similar so that others can reproduce the bug you're seeing? Thanks!
|
I tested in Ubuntu 16.04, CentOS 6.8 and OS X 10.11 and could reproduce except on OS X.
This one actually works in CentOS but failed in Ubuntu. Results change if I add c.txt and it will work as expected.
but then again, it fails if I explicitly specify the files.
Also, this last command gives different result on CentOS.
|
Do you happen to have any aliases set? Or are these all machines with a single core? I think I might have found the bug. |
Yup, got it, there's a bug when |
No I have no alias set. I have them in /usr/local/bin but in fact, I've downloaded the rg binary onto the same folder just in case and run it with, Ubuntu is on a single core and CentOS is on 4 cores. |
This was already working correctly in multithreaded mode, but in single threaded mode, a file failing to open caused search to stop. That's bad. Fixes BurntSushi#98.
Say, a directory contains
and if a.txt is not readable by the executing user, even if the pattern matches in the b.txt, rg quits saying,
I think it should continue searching when encountering these recoverable errors.
The text was updated successfully, but these errors were encountered: