globset: Add GlobSet::builder #2635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use inline code blocks for type names - Link to GlobSet
… as a likely more convenient version of GlobSetBuilder::new.
BurntSushi
approved these changes
Oct 16, 2023
BurntSushi
added
the
rollup
BurntSushi
pushed a commit
that referenced
this pull request
Oct 16, 2023
This avoids needing to import and call GlobSetBuilder::new explicitly. Closes #2635
BurntSushi
pushed a commit
that referenced
this pull request
Oct 16, 2023
This avoids needing to import and call GlobSetBuilder::new explicitly. Closes #2635
|
I'm not in a hurry to have this merged, but is it normal that it takes many weeks from creation of rollup to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a somewhat common pattern to have
Type::builderbe an alias forTypeBuilder::new(or even the only way of constructingTypeBuilder). It means you don't have to import the builder type separately for common usage.Thanks for this very handy small library 💚