Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code and doc fixes #307

Merged
merged 2 commits into from
Jan 8, 2017
Merged

Conversation

mernen
Copy link
Contributor

@mernen mernen commented Jan 8, 2017

The first commit is an oversight I spotted immediately after having #239 accepted.

The second one is just a minor divergence between the documentation and the actual code (Args::threads()). I'm assuming the code has the actual intended cap, as it's not too uncommon to find desktop machines with 12+ logical cores, it's still low enough not to accidentally overwhelm a modest (albeit modern) CPU, and it seems to be the more recent commit.

@mernen mernen changed the title Minor fixes Minor code and doc fixes Jan 8, 2017
@BurntSushi
Copy link
Owner

@mernen Thanks! :-)

I'm assuming the code has the actual intended cap, as it's not too uncommon to find desktop machines with 12+ logical cores, it's still low enough not to accidentally overwhelm a modest (albeit modern) CPU, and it seems to be the more recent commit.

Thanks for noticing this. The docs did indeed get out of sync. Note though that the default isn't necessarily 12, it's just capped at 12.

@BurntSushi BurntSushi merged commit 073ff35 into BurntSushi:master Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants