Color --replace text using the match type #625
Conversation
jamessan
force-pushed
the
color-replacment
branch
from
0007601 to
86ef072
Compare
src/printer.rs
Outdated
| fn new(replace: &'r [u8], count: &'r mut usize) -> CountingReplacer<'r> { | ||
| CountingReplacer { replace: replace, count: count } | ||
| fn new( | ||
| replace: &'r [u8], count: &'r mut usize, |
There was a problem hiding this comment.
Could you put each parameter on its own line please?
src/printer.rs
Outdated
| caps.expand(self.replace, dst); | ||
| let end = dst.len(); | ||
| if start != end { | ||
| self.offsets.push(Offset::new(start, dst.len())); |
There was a problem hiding this comment.
I feel like it would be clearer if this were written as Offset::new(start, end).
There was a problem hiding this comment.
Indeed. :) I originally didn't have the empty replacement check and forgot to change this to end when I added it. Thanks.
src/printer.rs
Outdated
| if line.last() != Some(&self.eol) { | ||
| self.write_eol(); | ||
| } | ||
| self.write_matched_line(offsets, &line[..], false); |
There was a problem hiding this comment.
I think &line should be sufficient here? I guess you might need &*line because line is a cow I think.
There was a problem hiding this comment.
Yeah, &*line is needed.
jamessan
force-pushed
the
color-replacment
branch
from
86ef072 to
b7613c5
Compare
src/printer.rs
Outdated
| caps.expand(self.replace, dst); | ||
| let end = dst.len(); | ||
| if start != end { | ||
| self.offsets.push(Offset::new(start, dst.len())); |
There was a problem hiding this comment.
Indeed. :) I originally didn't have the empty replacement check and forgot to change this to end when I added it. Thanks.
src/printer.rs
Outdated
| if line.last() != Some(&self.eol) { | ||
| self.write_eol(); | ||
| } | ||
| self.write_matched_line(offsets, &line[..], false); |
There was a problem hiding this comment.
Yeah, &*line is needed.
Thanks! My first contribution to a rust project. :) |
Closes #521