Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fixed-strings flag (fixes #964) #965

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Conversation

okdana
Copy link
Contributor

@okdana okdana commented Jun 25, 2018

Simple as this probably? I didn't add a test since i don't see any for other options like this, but let me know if you'd like one.

I also didn't update the completion function. I guess we need to decide whether it's useful to show all of the --no-* options; i'm leaning towards not usually. But i should add them as hidden options at least so that the exclusions are accurate. I'll do that eventually...

(Fixes #964)

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! And yeah, I'm not too particular about adding tests for these since I'm not sure they are worth it.

I defer to you on how to handle the zsh completions. :-)

@BurntSushi BurntSushi merged commit ac90316 into BurntSushi:master Jun 25, 2018
@okdana
Copy link
Contributor Author

okdana commented Jun 26, 2018

I just realised i mistyped the commit message on this. Sorry for the confusion that's going to cause in the future. :/

@BurntSushi
Copy link
Owner

@okdana Hah whoops. Missed that! Should be fine!

@jsatk
Copy link

jsatk commented Jun 26, 2018

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants