Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding imuf specific MSP settings #31

Merged
merged 7 commits into from
Apr 14, 2018
Merged

adding imuf specific MSP settings #31

merged 7 commits into from
Apr 14, 2018

Conversation

orneryd
Copy link
Contributor

@orneryd orneryd commented Apr 12, 2018

and hiding values we don't want set in the UI

Copy link
Member

@kidBrazil kidBrazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep multi-language support. We are going to automate that task on the new config but for now we gotta do it manually =(

@@ -2470,6 +2470,9 @@
"pidTuningKalmanFilterSettings": {
"message": "Kalman Filter Settings"
},
"pidTuningIMUFFilterSettings": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heheh.. you are not going to like this.. but we should add the keys for the other languages as well.

Copy link
Member

@kidBrazil kidBrazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orneryd we gotta remove the app-dmg from there... travis wont build that because its not compatible with linux.

package.json Outdated
@@ -35,6 +35,7 @@
"author": "The Butterflight open source project.",
"license": "GPL-3.0",
"dependencies": {
"gulp-appdmg": "^1.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app-dmg cannot be a dependency here if we are going to use travis.. it simply cannot be installed in travis because it is running on a linux environment.

We could stop using Travis for builds but that is not necessarily ideal.

@kidBrazil kidBrazil merged commit ca867a9 into master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants