New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion process on Rust 1.55 #107

Merged

Byron merged 1 commit into Byron:main from Bobo1239:main

Sep 18, 2021

Commits on Sep 17, 2021

Fix deletion process on Rust 1.55

Rust 1.55 unfortunately breaks the existing code which assumed that
ErrorKind::Other will be returned by fs::read_dir() when a file is
encountered. For now just always try deleting as if it's a file with the
possibility to add the optimization back again once the `io_error_more`
feature is stabilized.

References:
- https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#stdioerrorkind-variants-updated
- rust-lang/rust#85746
- rust-lang/rust#86442

Bobo1239 committed Sep 17, 2021