Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MSRV check to CI #80

Merged
merged 1 commit into from
Aug 20, 2024
Merged

add MSRV check to CI #80

merged 1 commit into from
Aug 20, 2024

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Aug 20, 2024

Adds an MSRV check to CI.

Checking the MSRV ensures that the minimum compiler version for this project is not inadvertently (/unintentionally) bumped by changes to dependencies or syntax.

I found the MSRV using cargo-msrv. Using cargo-no-dev-deps ensures that the dev dependencies don't contribute to the MSRV

@danieleades danieleades mentioned this pull request Aug 20, 2024
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

It's very interesting that the MSRV is this high - I definitely wasn't aware.

@Byron Byron merged commit 08ffcb8 into Byron:main Aug 20, 2024
2 checks passed
@danieleades danieleades deleted the msrv branch August 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants