Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Lower MSRV to 1.71.1 #81

Merged
merged 2 commits into from
Aug 22, 2024
Merged

build: Lower MSRV to 1.71.1 #81

merged 2 commits into from
Aug 22, 2024

Conversation

caspermeijn
Copy link
Contributor

This project builds successfully with the MSRV of pulldown-cmark. Therefore we can lower rust-version to 1.71.1.

Add documentation for the current MSRV and that this project follows MSRV policy of pulldown-cmark.

Use cargo hack for MSRV CI job, to automatically install rustc according to rust-version and then execute cargo check.

This project builds successfully with the MSRV of `pulldown-cmark`. Therefore we can lower `rust-version` to 1.71.1.

Add documentation for the current MSRV and that this project follows MSRV policy of `pulldown-cmark`.

Use `cargo hack` for MSRV CI job, to automatically install rustc according to `rust-version` and then execute `cargo check`.
@caspermeijn
Copy link
Contributor Author

Please let me know if you are not comfortable with providing this level of support, then I will change the PR accordingly.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this seems like a very reasonable thing to do!

Cargo.toml Show resolved Hide resolved
@Byron Byron merged commit 85ca9d4 into Byron:main Aug 22, 2024
2 checks passed
@Byron
Copy link
Owner

Byron commented Aug 22, 2024

@caspermeijn
Copy link
Contributor Author

Thanks for the swift reaction!

@caspermeijn caspermeijn deleted the msrv branch August 28, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants